Update regression.py added root_mean_square_deviation method #7531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Root mean square deviation (https://en.wikipedia.org/wiki/Root-mean-square_deviation) using numpy.sqrt() and previously defined mean_squared_error.
|
Needs pep8 and tests. I'm not sure it's worth adding a variant that's just different by the sqrt. Can you just do this post-processing? |
|
Let's make this a parameter to MSE, perhaps... is it worth adding a |
|
Superseded by #13467 as far as I can tell |
|
closed in #13467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
No issue
What does this implement/fix? Explain your changes.
This adds Root Mean Square Deviation method (https://en.wikipedia.org/wiki/Root-mean-square_deviation).
Any other comments?
Added Root mean square deviation (https://en.wikipedia.org/wiki/Root-mean-square_deviation) using numpy.sqrt() and previously defined mean_squared_error.