-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG + 1] FIX: Update install instructions for Windows #7550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm. |
For completeness, it looks like the flake8 error is very similar to the one noted in #7027 (comment). |
I think both the Pull request would need a rebase to fix the flake8 error. |
I merged #7575 and restarted the Travis flake8 build, that should get Travis green. |
@lesteve The CircleCI tests are failing. |
seems like there was an error in
|
The CircleCI error is weird, I tried to restart the build manually without cache to see whether that fixes it ... |
Seems like it did ... |
Is the PR ready for merging? |
Thanks for reminding us about this one ! @amueller gave his +1 above and it looks good to me as well so merging this one, thanks! |
Updates the Install instruction for scikit-learn in Windows to make use of WinPython instead of Python(x,y)