Skip to content

[MRG + 1] FIX: Update install instructions for Windows #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2016
Merged

[MRG + 1] FIX: Update install instructions for Windows #7550

merged 1 commit into from
Oct 7, 2016

Conversation

souravsingh
Copy link
Contributor

Updates the Install instruction for scikit-learn in Windows to make use of WinPython instead of Python(x,y)

@amueller amueller changed the title FIX: Update install instructions for Windows [MRG + 1] FIX: Update install instructions for Windows Oct 3, 2016
@amueller
Copy link
Member

amueller commented Oct 3, 2016

lgtm.

@lesteve
Copy link
Member

lesteve commented Oct 3, 2016

For completeness, it looks like the flake8 error is very similar to the one noted in #7027 (comment).

@souravsingh
Copy link
Contributor Author

I think both the Pull request would need a rebase to fix the flake8 error.

@lesteve
Copy link
Member

lesteve commented Oct 4, 2016

I merged #7575 and restarted the Travis flake8 build, that should get Travis green.

@souravsingh
Copy link
Contributor Author

@lesteve The CircleCI tests are failing.

@nelson-liu
Copy link
Contributor

seems like there was an error in plot_multioutput_face_completion. Try rerunning the CI (One way of doing it yourself is to do git commit --amend and force push)?

Traceback (most recent call last):
  File "/home/ubuntu/scikit-learn/doc/sphinxext/gen_rst.py", line 864, in generate_file_rst
    execfile(os.path.basename(src_file), my_globals)
  File "plot_multioutput_face_completion.py", line 28, in <module>
    data = fetch_olivetti_faces()
  File "/home/ubuntu/scikit-learn/sklearn/datasets/olivetti_faces.py", line 123, in fetch_olivetti_faces
    faces = joblib.load(filepath)
  File "/home/ubuntu/scikit-learn/sklearn/externals/joblib/numpy_pickle.py", line 459, in load
    obj = unpickler.load()
  File "/home/ubuntu/miniconda/envs/testenv/lib/python2.7/pickle.py", line 864, in load
    dispatch[key](self)
KeyError: 'x'

@lesteve
Copy link
Member

lesteve commented Oct 5, 2016

The CircleCI error is weird, I tried to restart the build manually without cache to see whether that fixes it ...

@lesteve
Copy link
Member

lesteve commented Oct 5, 2016

The CircleCI error is weird, I tried to restart the build manually without cache to see whether that fixes it ...

Seems like it did ...

@souravsingh
Copy link
Contributor Author

Is the PR ready for merging?

@lesteve
Copy link
Member

lesteve commented Oct 7, 2016

Is the PR ready for merging?

Thanks for reminding us about this one ! @amueller gave his +1 above and it looks good to me as well so merging this one, thanks!

@lesteve lesteve merged commit 1e3da55 into scikit-learn:master Oct 7, 2016
@souravsingh souravsingh deleted the add-doc branch October 7, 2016 09:21
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants