Skip to content

[MRG+1] Doc: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2016
Merged

[MRG+1] Doc: Explain the meaning of prefix [MRG + 1] and [MRG + 2] in the title of the pull request. #7636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions doc/developers/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,13 @@ rules before submitting a pull request:

* Please prefix the title of your pull request with ``[MRG]`` if the
contribution is complete and should be subjected to a detailed review.
Incomplete contributions should be prefixed ``[WIP]`` to indicate a work
in progress (and changed to ``[MRG]`` when it matures). WIPs may be useful
to: indicate you are working on something to avoid duplicated work,
request broad review of functionality or API, or seek collaborators.
WIPs often benefit from the inclusion of a
Two core developers will review your code and change the prefix of the pull
request to ``[MRG + 1]`` and ``[MRG + 2]`` on approval, making it eligible
for merging. Incomplete contributions should be prefixed ``[WIP]`` to
indicate a work in progress (and changed to ``[MRG]`` when it matures).
WIPs may be useful to: indicate you are working on something to avoid
duplicated work, request broad review of functionality or API, or seek
collaborators. WIPs often benefit from the inclusion of a
`task list
<https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments>`_
in the PR description.
Expand Down