[MRG + 1] Call sorted on lfw folder path contents when fetching so results are … #7648
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent across operating systems (scikit-learn#6484)
|
LGTM |
|
In the vein of #7647, you could include an attribute listing the source paths in the bunch, and hence be able to add a test for the path ordering... |
|
hey @jnothman, I'd like to work on adding the bunch attribute. |
|
well, it's going to be returned by |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
when fetching so results are consistent across operating systems
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
when fetching so results are consistent across operating systems
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
when fetching so results are consistent across operating systems
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
when fetching so results are consistent across operating systems
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
when fetching so results are consistent across operating systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #6484
What does this implement/fix? Explain your changes.
This simply calls sort on the image directory in lfw as the issue reporter suggested.
Any other comments?
…consistent across operating systems (#6484)