Skip to content

[MRG + 1] Clarified error msg in plot_partial_dependence #7673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2016
Merged

[MRG + 1] Clarified error msg in plot_partial_dependence #7673

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4ecf38
Clarified error msg in plot_partial_dependence
kgilliam125 Oct 14, 2016
b880944
Changed err msg for feature[i] out of range. Updated docs.
kgilliam125 Oct 18, 2016
c524aff
Error message shows invalid value.
kgilliam125 Oct 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions sklearn/ensemble/partial_dependence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,14 @@ def plot_partial_dependence(gbrt, X, features, feature_names=None,
A fitted gradient boosting model.
X : array-like, shape=(n_samples, n_features)
The data on which ``gbrt`` was trained.
features : seq of tuples or ints
features : seq of ints, strings, or tuples of ints or strings
If seq[i] is an int or a tuple with one int value, a one-way
PDP is created; if seq[i] is a tuple of two ints, a two-way
PDP is created.
If feature_names is specified and seq[i] is an int, seq[i]
must be < len(feature_names).
If seq[i] is a string, feature_names must be specified, and
seq[i] must be in feature_names.
feature_names : seq of str
Name of each feature; feature_names[i] holds
the name of the feature with index i.
Expand Down Expand Up @@ -306,8 +310,9 @@ def convert_feature(fx):
l.append(feature_names[i])
names.append(l)
except IndexError:
raise ValueError('features[i] must be in [0, n_features) '
'but was %d' % i)
raise ValueError('All entries of features must be less than '
'len(feature_names) = {0}, got {1}.'
.format(len(feature_names), i))

# compute PD functions
pd_result = Parallel(n_jobs=n_jobs, verbose=verbose)(
Expand Down