[WIP] replaced n_iter by max_iter and added deprecation #7761
Conversation
sklearn/manifold/t_sne.py
Outdated
| @@ -644,8 +645,10 @@ class TSNE(BaseEstimator): | |||
| http://lvdmaaten.github.io/publications/papers/JMLR_2014.pdf | |||
| """ | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
The @property is just for deprecating attributes, not functions. That's why the tests fail, I think.
|
You can isolate tests with the command: Note that this is currently breaking user's code, for example if they have |
|
Thanks for the feedback. I still get a few errors in the test coming from the https://travis-ci.org/scikit-learn/scikit-learn/jobs/171341699 |
| fit_intercept=True, normalize=False, copy_X=True, | ||
| verbose=False): | ||
| if n_iter is not None: | ||
| warnings.warn("'n_iter' was deprecated. Use 'max_iter' instead.") |
There was a problem hiding this comment.
Please raise a DeprecationWarning
You also need to use this value if provided, so that the result of `ARDRegression(n_iter=10).fit(...)``is not modify by this PR:
self.n_iter = n_iter
if n_iter is not None:
warnings.warn(...)
self.max_iter = n_iter
else:
self.max_iter = max_iter(same in other classes)
| threshold_lambda=1.e+4, fit_intercept=True, normalize=False, | ||
| copy_X=True, verbose=False): | ||
| self.n_iter = n_iter | ||
| @deprecated("Attribute n_iter was deprecated. Use 'max_iter' instead") |
There was a problem hiding this comment.
you need to remove this line (same in other classes)
Reference Issue
#7736
What does this implement/fix? Explain your changes.
I have replaced
n_iterbymax_iterand added thedeprecateddecorators in the methods discussed in #7736.Any other comments?
The tests are not passing yet and I have a hard time to debug without test isolation. How can I isolate the file I want to test?