[WIP] DOC Description of X missing in KMeans.fit (#7772) #7775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @ditenberg, the PR diff seems incorrect, could you check? |
|
Hi @raghavrv, yes I noticed that too. I think it's because I accidentally referenced the wrong issue (one number off) in the pushes to my repo before sending a pull request. I will fix it. |
|
Once you fix that please ping me again? |
raghavrv
suggested changes
Oct 28, 2016
| X : array-like, shape = [n_samples, n_features] | ||
| Coordinates of the data points to cluster | ||
| X : array-like or sparse matrix, shape=(n_samples, n_features) | ||
| Training instances to cluster |
There was a problem hiding this comment.
For now we can have it as
Training data to cluster.
A more general docstring which is standardized across the codebase will be addressed by fixing #3791 later...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issue #7772:
Added "Training instances to cluster" as explanation in fit() methods in k_means_.py. Also made both docstring match in terms of parameter descriptions for X in fit(): "X : array-like or sparse matrix, shape=(n_samples, n_features)". This convention is according to that proposed by amueller in #3791.