[MRG] DOC Description of X missing in KMeans.fit (#7772) #7783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reference to scikit-learn#7772
|
Hi @raghavrv, here is a new pull request with only the changes to the fit() methods in k_means_.py. I'm sorry for the confusion earlier I must have made a mistake when I was pushing to my forked repo and referenced the wrong issue number. I deleted my old branches I was working on to make a fresh one. This should be a clean pull request. Please let me know if there are anymore issues. |
|
LGTM, thanks! |
|
Thanks @ditenberg! |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Nov 9, 2016
In reference to scikit-learn#7772
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
In reference to scikit-learn#7772
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
In reference to scikit-learn#7772
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
In reference to scikit-learn#7772
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
In reference to scikit-learn#7772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issue #7772:
Added "Training instances to cluster" as explanation in fit() methods in k_means_.py. Also made both docstring match in terms of parameter descriptions for X in fit(): "X : array-like or sparse matrix, shape=(n_samples, n_features)". This convention is according to that proposed by amueller in #3791.