Skip to content

[MRG + 1] Label warning #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 24, 2017
Merged

[MRG + 1] Label warning #7802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cd05c8d
Added warning for classification_report when target_names doesn't equ…
kennethjmyers Oct 31, 2016
2284895
Update test_classification.py
Oct 31, 2016
3d79757
added fix for optional target names
Nov 1, 2016
d9ca34b
second attempt to handle optional target_names
Nov 1, 2016
f070f4a
fixed white space error
Nov 1, 2016
a07378f
fixed other whitespace issue
Nov 1, 2016
579ef7a
more whitespace issues
Nov 1, 2016
ae39702
test warning message updated
Nov 1, 2016
0226700
added labels and target_names lengths to warning
Nov 1, 2016
9889c0b
missing )
Nov 1, 2016
6a27198
fixed line length
kennethjmyers Nov 1, 2016
51fb206
fixed line length issue in test_classification.py
kennethjmyers Nov 1, 2016
6ee537d
fixed formatting for python 2.6
Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sklearn/metrics/classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,6 +1392,12 @@ class 2 1.00 0.67 0.80 3
else:
labels = np.asarray(labels)

if target_names is not None and len(labels) != len(target_names):
warnings.warn(
"labels size, {0}, does not match size of target_names, {1}"
.format(len(labels), len(target_names))
)

last_line_heading = 'avg / total'

if target_names is None:
Expand Down
12 changes: 12 additions & 0 deletions sklearn/metrics/tests/test_classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,18 @@ def test_classification_report_multiclass_with_long_string_label():
assert_equal(report, expected_report)


def test_classification_report_labels_target_names_unequal_length():
y_true = [0, 0, 2, 0, 0]
y_pred = [0, 2, 2, 0, 0]
target_names = ['class 0', 'class 1', 'class 2']

assert_warns_message(UserWarning,
"labels size, 2, does not "
"match size of target_names, 3",
classification_report,
y_true, y_pred, target_names=target_names)


def test_multilabel_classification_report():
n_classes = 4
n_samples = 50
Expand Down