[MRG + 1] DOC Add whatsnew for the 3 model_selection bugfixes #7868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Nov 14, 2016
| @@ -104,6 +104,23 @@ Bug fixes | |||
| the same result as the LassoLars implementation available | |||
| in R (lars library). :issue:`7849` by `Jair Montoya Martinez`_ | |||
|
|
|||
| - Fixed a bug where :func:`sklearn.model_selection.train_test_split` raised | |||
There was a problem hiding this comment.
those should be under 0.18.1.
Also, some of the links with your username don't render properly in the 0.18.1 whatsnew. Would you mind checking?
|
thanks LGTM |
7cae83d to
99082d9
Compare
|
Thx @tguillemot @jnothman Another review please? |
tguillemot
approved these changes
Nov 15, 2016
| @@ -93,7 +93,8 @@ Olivier Grisel <olivier.grisel@ensta.org> <olivier.grisel@ensta.org> | |||
| Olivier Hervieu <olivier.hervieu@gmail.com> <olivier.hervieu@tinyclues.com> | |||
| Paul Butler <paulgb@gmail.com> | |||
| Peter Prettenhofer <peter.prettenhofer@gmail.com> | |||
| Raghav R V <rvraghav93@gmail.com> | |||
| Raghav RV <rvraghav93@gmail.com> | |||
| Raghav RV <rvraghav93@gmail.com> <ragvrv@gmail.com> | |||
There was a problem hiding this comment.
Why have you put it both ?
There was a problem hiding this comment.
The first one creates an entry for my correct name mapped to my correct email and the 2nd maps my other e-mail to the first one... (I think)
|
Thanks, I'm merging... :) |
tguillemot
pushed a commit
to tguillemot/scikit-learn
that referenced
this pull request
Nov 15, 2016
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
tguillemot
pushed a commit
to tguillemot/scikit-learn
that referenced
this pull request
Nov 15, 2016
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
|
This should be backported to the 0.18.X branch? |
|
I think yes... Pinging Andy @amueller |
|
After doing so, the docs for stable have to be rebuilt and pushed right? or does it happen automatically? |
|
works automagically :) |
amueller
added a commit
to amueller/scikit-learn
that referenced
this pull request
Nov 16, 2016
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email # Conflicts: # doc/whats_new.rst
|
backported |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…-learn#7868) * DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds whatsnew for #7593 #7594 and #7660
Ping @amueller @jnothman