-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[MRG + 1] DOC add sklearn-crfsuite to related projects #7878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM. I'd really like to see related projects, vis a vis projects with a compatible/similar API, becoming a more freely managed catalogue to emphasise that scikit-learn is (in one of its manifestations) an ecosystem. Any ideas how best to achieve that? |
Options:
|
Maybe in |
@raghavrv Having it in scikit-learn-contrib organization makes sense: not all packages can be moved to scikit-learn-contrib organization even if they satisfy all conditions - e.g. a company may want to keep a repo under its name, or someone may disagree with giving commit and admin access to a third party even if it is a highly trusted third party. |
Indeed. I'm suggesting just for the links. (Instead of a new org/repository I'm suggesting so because |
Other thing you've subtly pointed out to me is that we don't want this to On 15 November 2016 at 22:50, Mikhail Korobov notifications@github.com
|
Is it too unfettered to let the wiki store a YaML listing that could then On 16 November 2016 at 08:07, Joel Nothman joel.nothman@gmail.com wrote:
|
We do have this page.
Yes and so scikit-learn should focus more on solving the hard problems (model selection, sample weights, etc). |
If we put this into scikit-learn-contrib we don't need an additional CI process. |
👍 to merge this now, add the "related projects" to "scikit-learn-contrib" and then just link to there from here. |
The advantage of a dedicated repo either under I am actually wondering if we should simply name it |
I don't understand. Why is that easier for a |
The contrib is for projects that are hosted in that repo. The I was expecting scikit-contrib itself to be one such link inside that repo... |
Yeah but why does that need a separate repo instead of a section in the readme? that seems overkill |
I'd rather not clutter the README file with non-contrib projects. And if we start referencing non-contrib projects, what's the benefit of becoming a contrib project? I don't feel that we receive so many related-project PRs that we need to rethink our workflow. |
I'm merging this for now. We can have a separate discussion on this if needed... |
Thanks @kmike |
What do you think about adding sklearn-crfsuite to related projects?
It is a https://github.com/chokkan/crfsuite wrapper which provides a CRF estimator with API similar to scikit-learn (compatible with e.g. sklearn model selection utilities). There are also some sklearn-compatible metrics and scorers for sequence classification tasks (though not many).
Another simiilar package is https://github.com/jakevdp/pyCRFsuite, but it is unmaintained.