[MRG + 1] Added a random_state=0 to many make_classification tests #7968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavrv
approved these changes
Dec 2, 2016
| @@ -278,7 +278,7 @@ def test_consistency_path(): | |||
|
|
|||
| def test_liblinear_dual_random_state(): | |||
| # random_state is relevant for liblinear solver only if dual=True | |||
| X, y = make_classification(n_samples=20) | |||
| X, y = make_classification(n_samples=20, random_state=0) | |||
There was a problem hiding this comment.
42 would have made @agramfort happier ;)
There was a problem hiding this comment.
As @chenhe95 is new to the project I think it's ok to be allow it. Now he knows better ;)
Thanks for the detective work and fix!
|
I can live with 0 but 42 is the magic number indeed ! |
4 tasks
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#7966
What does this implement/fix? Explain your changes.
Before, there were non-deterministic failures due to not setting random_state when testing on make_classification()