[MRG] ENH Allow handling nan during input validation #8074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavrv
commented
Dec 18, 2016
| def any_not_isfinite(X): return np.isinf(X).any() | ||
| np_sum = np.nansum | ||
| else: | ||
| def any_not_isfinite(X): return not np.isfinite(X).all() |
There was a problem hiding this comment.
@jnothman I fixed your comment in this PR...
raghavrv
commented
Dec 18, 2016
| @@ -138,6 +138,11 @@ def test_check_array(): | |||
| X_nan[0, 0] = np.nan | |||
| assert_raises(ValueError, check_array, X_nan) | |||
| check_array(X_inf, force_all_finite=False) # no raise | |||
There was a problem hiding this comment.
This tests for force_all_finite=False, allow_nan=False
|
Arghh sorry for the noise. I think #7892 itself is representative and small enough breaking down may make it non-functional unit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a tiny part refactored out of #5974 and #7892 to keep the other PRs concise and easy to review...
This adds support for allowing
nan(one of the common placeholders for missing values) in the data matrix,X, while still filtering outinfas a part of input validation done by thecheck_array,check_all_finitehelpers...@tguillemot @jnothman @amueller @glouppe @agramfort Reviews please :)