CI limit diff to commit range #8097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed not sure what happened there. In the Travis case COMMIT was unset so I am not sure what the diff was doing ... |
|
It's not a problem of variable scope, is it?
…On 21 December 2016 at 23:01, Loïc Estève ***@***.***> wrote:
Indeed not sure what happened there. In the Travis case COMMIT was unset
so I am not sure what the diff was doing ...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8097 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz61BZk9O7nAlYksakM1ETMWYoYlQwks5rKRULgaJpZM4LS3cO>
.
|
Actually my bad, I was not reading the code correctly. COMMIT is unset only for a push into a branch (i.e. not a PR) on Travis. Anyway I think your original guess is correct HEAD is the result of the merge of the PR into master and that is what we are diffing against. Your fix looks good to me and Travis is green so I'll merge it |
|
Thanks a lot for diagnosing the problem and fixing it! |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to be getting some spurious flake8 errors in Travis. I think it is because the diff of merge-base is being used relative to HEAD (merged master with PR head?) instead of the commit range from merge-base to PR head.
Example of spurious errors: https://travis-ci.org/scikit-learn/scikit-learn/jobs/185733709