Updated documentation for #7947 #8196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Jan 14, 2017
| @@ -221,7 +221,8 @@ class PCA(_BasePCA): | |||
| The estimated number of components. When n_components is set | |||
| to 'mle' or a number between 0 and 1 (with svd_solver == 'full') this | |||
| number is estimated from input data. Otherwise it equals the parameter | |||
| n_components, or n_features if n_components is None. | |||
| n_components, or n_features if n_components is None. For PCA to work | |||
| properly, keep n_samples > n_components. | |||
There was a problem hiding this comment.
this is not specific enough. What do you mean by "properly". eg Will it crash?
nelson-liu
reviewed
Jan 19, 2017
| @@ -221,7 +221,8 @@ class PCA(_BasePCA): | |||
| The estimated number of components. When n_components is set | |||
| to 'mle' or a number between 0 and 1 (with svd_solver == 'full') this | |||
| number is estimated from input data. Otherwise it equals the parameter | |||
| n_components, or n_features if n_components is None. | |||
| n_components, or n_features if n_components is None. For PCA to work | |||
There was a problem hiding this comment.
i know they weren't there before, but I think double backticks around the parameter names and None would be good here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#7947