Skip to content

[WIP] Modify SVR example for better plot #8367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] Modify SVR example for better plot #8367

wants to merge 2 commits into from

Conversation

rishikksh20
Copy link
Contributor

@rishikksh20 rishikksh20 commented Feb 15, 2017 •
edited
Loading

Reference Issue

Closes: #8365

What does this implement/fix? Explain your changes.

Change coef0 value for better plot of poly kernal. Also
improve the support vectors marking in SVR plot.

Any other comments?

Stable : stable version
PR : PR version

@rishikksh20
Modify SVR example for better plot
944be8c 
Change coef0 value for better plot of poly kernal. Also
improve the support vectors marking in SVR plot.

Fixes: #8365
@rishikksh20 rishikksh20 changed the title [MRG] Modify SVR example for better plot [WIP] Modify SVR example for better plot Feb 15, 2017
@lesteve
Copy link
Member

lesteve commented Feb 16, 2017 •
edited
Loading

Please fix the flake8 errors and invest some time in setting up on-the-fly flake8 checks in your editor of choice.

Also to make the comparison easier, please add the links for the example on stable, dev and your PR.

@rishikksh20
Modify plot_svm_regression for removing flake8 error
73ba352 
Format a code to remove flake8 error from travis build

Issue: #8365
@codecov
Copy link

codecov bot commented Feb 16, 2017 •
edited
Loading

Codecov Report

Merging #8367 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8367   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         342      342           
  Lines       60801    60801           
=======================================
  Hits        57609    57609           
  Misses       3192     3192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d57730...73ba352. Read the comment docs.

@jnothman jnothman mentioned this pull request Nov 7, 2017
Closed
@jnothman
Copy link
Member

jnothman commented Nov 8, 2017 •
edited
Loading

Are you still working on this @rishikksh20 ?

@jnothman
Copy link
Member

jnothman commented Nov 8, 2017

I think the support vector markers should be smaller, and coloured to match their corresponding model.

@jnothman
Copy link
Member

jnothman commented Nov 8, 2017

Though I'm inclined to agree that support vectors don't help here unless they're on separate plots for each kernel, which would be interesting to try.

@ml4713 ml4713 mentioned this pull request Sep 29, 2018
Closed
@vasudhathinks
Copy link

working on this with @ml4713

@ml4713 ml4713 mentioned this pull request Sep 29, 2018
Closed
@rishikksh20
Copy link
Contributor Author

@vasudhathinks go ahead

This was referenced Dec 27, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVR example misleading
4 participants
@rishikksh20 @lesteve @jnothman @vasudhathinks