Skip to content

Fixing #8484 #8485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fixing #8484 #8485

wants to merge 3 commits into from

Conversation

wallygauze
Copy link
Contributor

Reference Issue

Fixes #8484

What does this implement/fix? Explain your changes.

  • n_component parameter documentation, & mentions elsewhere in parameters section
  • n_components_ attribute documentation
  • 'Handling n_components==None' code in _fit method
  • Extended (to include n_samples as a limit) relevant ValueError in _fit_full method
  • Extended ValueError raised for (not 1 <= n_components <= n_features) and ValueError raised for (svd_solver == 'arpack' and n_components == n_features) in _fit_truncated

unrelated extra:

  • corrected documentation for explained_variance_ratio_ attribute

Any other comments?

@wallygauze wallygauze closed this Mar 1, 2017
@wallygauze wallygauze deleted the pca_error branch March 1, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

n_components in PCA explicitly limited by n_features only
1 participant
@wallygauze