Skip to content

Doc for TfidfTransformer.idf_ #8532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Doc for TfidfTransformer.idf_ #8532

wants to merge 2 commits into from

Conversation

ekellbuch
Copy link

Reference Issue

Fixes #8267

@codecov
Copy link

codecov bot commented Mar 4, 2017

Codecov Report

Merging #8532 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #8532   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         342      342           
  Lines       60913    60913           
=======================================
  Hits        58160    58160           
  Misses       2753     2753
Impacted Files Coverage Δ
sklearn/feature_extraction/text.py 96.05% <100%> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1796e...864993a. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2017

Codecov Report

Merging #8532 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #8532   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         342      342           
  Lines       60913    60913           
=======================================
  Hits        58160    58160           
  Misses       2753     2753
Impacted Files Coverage Δ
sklearn/feature_extraction/text.py 96.05% <100%> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1796e...864993a. Read the comment docs.

jmschrei
jmschrei reviewed Mar 4, 2017
View reviewed changes
sklearn/feature_extraction/text.py
@@ -996,6 +996,12 @@ class TfidfTransformer(BaseEstimator, TransformerMixin):
sublinear_tf : boolean, default=False
Apply sublinear tf scaling, i.e. replace tf with 1 + log(tf).

Attributes
----------
idf_ : numpy array of shape [n_features, 1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class doesn't seem to have or use a self.idf_ attribute. Do you mean self._idf_diag?

@jmschrei
Copy link
Member

jmschrei commented Mar 4, 2017

This and #8528 appear to be duplicates. Please close one and proceed with the other.

@raghavrv raghavrv mentioned this pull request Mar 7, 2017
Closed
@raghavrv raghavrv closed this Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jmschrei jmschrei jmschrei left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekellbuch @jmschrei @NelleV @raghavrv