Skip to content

[MRG] remove "matplotlib v<1" from manifold examples #8552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2017
Merged

[MRG] remove "matplotlib v<1" from manifold examples #8552

merged 6 commits into from
Mar 10, 2017

Conversation

rishikksh20
Copy link
Contributor

@rishikksh20 rishikksh20 commented Mar 7, 2017 •
edited
Loading

Reference Issue

Fix #8545

What does this implement/fix? Explain your changes.

Correct the position of the comment.

Any other comments?

@lesteve
Copy link
Member

lesteve commented Mar 7, 2017

See my comment in the associated issue: #8545 (comment).

Also please use "Fix #issueNumber" this way the associated issue gets closed automatically when the PR is merged. For more details, look at this.

@rishikksh20 rishikksh20 changed the title [WIP] remove "matplotlib v<1" fron manifold examples [MRG] remove "matplotlib v<1" fron manifold examples Mar 9, 2017
@rishikksh20 rishikksh20 changed the title [MRG] remove "matplotlib v<1" fron manifold examples [MRG] remove "matplotlib v<1" from manifold examples Mar 9, 2017
@rishikksh20 rishikksh20 changed the title [MRG] remove "matplotlib v<1" from manifold examples [WIP] remove "matplotlib v<1" from manifold examples Mar 9, 2017
lesteve
lesteve reviewed Mar 9, 2017
View reviewed changes
examples/manifold/plot_compare_methods.py
ax = fig.add_subplot(251, projection='3d')
plt.scatter(X[:, 0], X[:, 2], c=color, cmap=plt.cm.Spectral)

ax = fig.add_subplot(251, projection='3d')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I believe the comment it looks like you kept the matplotlib < 1 code. The comment may have been misplaced. You should double-check that view_init does not work for matplotlib < 1. Double-check for your other changes too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let me check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lesteve all examples running good.

@rishikksh20
Correct the comment position
81a193f 
Except part is for compatibility

Issue: #8545
@rishikksh20
Correct the position of comment plot_manifold_sphere
d421d77 
Except part is for compatibility

Issue: #8545
@rishikksh20
Correct comment position in plot_swissroll
5e3b1b8 
Issue: #8545
@rishikksh20
Remove matplotlib < 1.0 compatibility code
bfee206 
Remove the block of codes which are placed for
matplot lib < 1 compatibility

Issue: #8545
@rishikksh20
Add minimum matplolib version for scikit-learn
c86d049 
Add the minimum requirement of matplotlib for
running examples in README.
@rishikksh20 rishikksh20 changed the title [WIP] remove "matplotlib v<1" from manifold examples [MRG] remove "matplotlib v<1" from manifold examples Mar 10, 2017
@lesteve
Copy link
Member

lesteve commented Mar 10, 2017

LGTM, merging, thanks!

@lesteve lesteve merged commit d0ce40e into scikit-learn:master Mar 10, 2017
@rishikksh20 rishikksh20 deleted the refractor_comment_matplotlib branch March 10, 2017 07:45
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
@rishikksh20 @herilalaina
[MRG] remove "matplotlib <1" compatibility code from manifold examples (
654442e 
scikit-learn#8552)
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
@rishikksh20
[MRG] remove "matplotlib <1" compatibility code from manifold examples (
12a8df1 
scikit-learn#8552)
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@rishikksh20 @Sundrique
[MRG] remove "matplotlib <1" compatibility code from manifold examples (
2ce9b33 
scikit-learn#8552)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@rishikksh20 @NelleV
[MRG] remove "matplotlib <1" compatibility code from manifold examples (
47b303c 
scikit-learn#8552)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@rishikksh20 @paulha
[MRG] remove "matplotlib <1" compatibility code from manifold examples (
4609d94 
scikit-learn#8552)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@rishikksh20 @maskani-moh
[MRG] remove "matplotlib <1" compatibility code from manifold examples (
17ae7e1 
scikit-learn#8552)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@rishikksh20
[MRG] remove "matplotlib <1" compatibility code from manifold examples (
339ef5e 
scikit-learn#8552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove "matplotlib v<1" compatibility code
2 participants
@rishikksh20 @lesteve