fix for PR # 7902, #7898 and # 8115 #8593
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you add "x" into list "version"(change to tuple) at return statement if x is NOT digits, this will cause type error later when you compare tuple (1,12,'1rc1) to tuple (1,12,0). Two possible solution.
Hope somebody will merge my fix into next release because I'm NOT a contributor.
...
import re
...
def _parse_version(version_string):
version = []
for x in version_string.split('.'):
try:
version.append(int(x))
except ValueError:
x may be of the form dev-1ea1592
version.append(x)
digits=re.match(r'^(\d)+\D',x)
if digits:
version.append(int(digits.group(1)))
else:
use 0 if no leading digits found
version.append(0)
return tuple(version)
Test environment:
Python 3.4
Numpy 1.12.1rc1
sklearn 0.18.1
Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?