[MRG+2] Limiting n_components by both n_features and n_samples instead of just n_features (Recreated PR)#8742

Merged

jnothman merged 26 commits intoscikit-learn:masterfrom

wallygauze:pca_8484_2

Sep 9, 2017

Commits on Apr 11, 2017

fixed issue 8484

Wally
authored and
wallygauze
committed
dealt with indentation issues flagged by flake8

Wally
authored and
wallygauze
committed
code to handle n_components==None with arpack was missing

Wally
authored and
wallygauze
committed
added non-regression tests for my previous changes in pca

Wally
authored and
wallygauze
committed
minor change: reverted iterator name in test_pca

Wally
authored and
wallygauze
committed
changed AssertRaises to regex variant in test, and minor writing change in docs

Wally
authored and
wallygauze
committed

Commits on May 27, 2017

corrected pca.py fix
Wally
committed
improved test_pca_validation()'s scope
Wally
committed

Commits on Aug 15, 2017

Commits on Aug 18, 2017

corrected whats_new entry typo
Wally
committed
arpack case was missing from test; improved overall test
Wally
committed
flake8 corrections
Wally
committed

Commits on Aug 19, 2017

arpack case was still missing + fixed my test bug + more refactoring
Wally
committed
corrected typo
Wally
committed

Commits on Aug 20, 2017

allow type long?
Wally
committed

Commits on Aug 22, 2017

accidentally left useless piece of code
Wally
committed

Commits on Sep 6, 2017

Merge branch 'master' into pca_8484_2
wallygauze
authored

Commits on Sep 8, 2017