[WIP] added comments to tree splitter code #8779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
April 22, 2017 15:24
… randomly drawn is chosen
…constant -> ...constants
…the features array
…nstant in this node
|
I am not convinced that we should add more comments. The code should self-document and additional comments can highlight some non-straightforward behavior, which seems the case for this code. |
|
I am also +0 for adding in more comments, in that I am not against them in general but don't see these are necessary. |
|
Closing, as reviewers appeared unconvinced about adding more comments to that code, and there has been no activity here since 2017. Sorry, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Does not fix any issue but should help advance #3628 .
What does this implement/fix? Explain your changes.
No code changes, just adding comments to better understand
what the code in tree/_splitter.pyx does.
Any other comments?
I noticed that I made most of the comment additions only to the
first class (BestSplitter) and it looks like there is quite some code duplication.
If deemed useful, I can also add the same comment additions to the
other three splitter classes in tree/_splitter.pyx (hence this PR is marked as [WIP]).
On the other hand, if #3628 is going to be addressed soon, it may not be useful to
duplicate such comments.