[MRG+2] ENH add memory to make_pipeline #8831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
May 7, 2017
sklearn/pipeline.py
Outdated
| @@ -549,7 +561,8 @@ def make_pipeline(*steps): | |||
| ------- | |||
| p : Pipeline | |||
| """ | |||
| return Pipeline(_name_estimators(steps)) | |||
| memory = kwargs.pop('memory', None) | |||
| return Pipeline(_name_estimators(steps), memory=memory) | |||
There was a problem hiding this comment.
Please ensue that an error is raised if there are other keyword args to make_pipeline. Easiest way to do that is just to forward **kwargs in entirety.
|
LGTM, thanks! |
|
Great!
|
Terryhung
pushed a commit
to Terryhung/scikit-learn
that referenced
this pull request
May 9, 2017
[MRG+2] ENH add memory to make_pipeline
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
[MRG+2] ENH add memory to make_pipeline
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
[MRG+2] ENH add memory to make_pipeline
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
[MRG+2] ENH add memory to make_pipeline
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
[MRG+2] ENH add memory to make_pipeline
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
[MRG+2] ENH add memory to make_pipeline
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
[MRG+2] ENH add memory to make_pipeline
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
[MRG+2] ENH add memory to make_pipeline
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
[MRG+2] ENH add memory to make_pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
No issue
What does this implement/fix? Explain your changes.
make_pipelinecan now buildPipelinewith cache memory;Any other comments?