[MRG] Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV #8847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dSearchCV and GridSearchCV
|
it should be 2 rather than 1.0
and we should have a CI test for non-plotted examples or convert as many as
possible to plots
…On 9 May 2017 6:37 am, "Manraj Singh" ***@***.***> wrote:
Fixes min_samples_split values for RandomizedSearchCV and GridSearchCV in
the example used in documentation.
Reference Issue
None
What does this implement/fix? Explain your changes.
Fixes ValueError: min_samples_split must be at least 2 or in (0, 1], got 1
error in examples/model_selection/randomized_search.py
<https://github.com/scikit-learn/scikit-learn/blob/master/examples/model_selection/randomized_search.py>
Any other comments?
None
------------------------------
You can view, comment on, or merge this pull request online at:
#8847
Commit Summary
- Randomized Search Example: Fix min_samples_split values for
RandomizedSearchCV and GridSearchCV
File Changes
- *M* examples/model_selection/randomized_search.py
<https://github.com/scikit-learn/scikit-learn/pull/8847/files#diff-0>
(4)
Patch Links:
- https://github.com/scikit-learn/scikit-learn/pull/8847.patch
- https://github.com/scikit-learn/scikit-learn/pull/8847.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8847>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAEz63gmmNIqbrFhCzBk-eNYOX-eKrk_ks5r330EgaJpZM4NUdyC>
.
|
At one point @ogrisel suggested that we should have a convention like I quickly looked at it at the time and there are at least a few of the 17 non I'll open a separate issue about this. |
|
Into and floats are interpreted differently here. Integer 1 is not allowed.
Float 1.0 indicates 100%
…On 10 May 2017 3:34 am, "Manraj Singh" ***@***.***> wrote:
@jnothman <https://github.com/jnothman> Made the required change. 😄 I
have a question though. If error says (0, 1], why does it fail on 1 when it
should not and not on 1.0 to maintain consistency? Is it a bug (and known)?
Yes, we should definitely build all examples.
@lesteve <https://github.com/lesteve> That's great! I can help fixing
that. 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz607-iuZ6i03oyDDEeafywn9mHCemks5r4KOJgaJpZM4NUdyC>
.
|
|
Thanks |
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…domizedSearchCV and GridSearchCV (scikit-learn#8847) * Randomized Search Example: Fix min_samples_split values for RandomizedSearchCV and GridSearchCV * Randomized Search Example: Change min_samples_split from 1.0 -> 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
min_samples_splitvalues for RandomizedSearchCV and GridSearchCV in the example used in documentation.Reference Issue
None
What does this implement/fix? Explain your changes.
Fixes
ValueError: min_samples_split must be at least 2 or in (0, 1], got 1error in examples/model_selection/randomized_search.pyAny other comments?
None