Skip to content

[MRG] Run more examples as part of the doc generation #8851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2017
Merged

[MRG] Run more examples as part of the doc generation #8851

merged 3 commits into from
May 11, 2017

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented May 10, 2017 •
edited
Loading

Fix the simplest part of #8849. Also fix some errors of existing examples.

@lesteve
Copy link
Member Author

lesteve commented May 10, 2017

FYI on my laptop running the additional examples takes about 2 minutes. Since the CircleCI build is about 40 minutes, this is not a big deal.

@lesteve
Copy link
Member Author

lesteve commented May 10, 2017

sphinx-gallery seems to have issues running examples that make use of sys.argv. The problem is that arguments of sphinx-build are passed into the example arguments. Probably something to fix on the sphinx-gallery side. In the mean time, I rename these examples back to their original name so that they do not get run.

@lesteve
Copy link
Member Author

lesteve commented May 10, 2017

Also I would be in favour of ignoring the flake8 errors (which is why Travis is red) to keep this PR as simple as possible.

@lesteve
Copy link
Member Author

lesteve commented May 11, 2017

@glemaitre if you have some time to look at this one, that would be great !

@glemaitre
Copy link
Member

ok

@glemaitre
Copy link
Member

glemaitre commented May 11, 2017 •
edited
Loading

LGTM. Below, a TODO list which might be moved to another issue/PR with the PEP8 issues.

TODO in either another PR or this one:

  • in plot_bicluster_newsgroups -> remove the "Output" section from the docstring.
  • in plot_feature_selection_pipeline.py -> improve the example with some nicer outputs.

@naoyak
Copy link
Contributor

naoyak commented May 11, 2017

See #8864 for a fix for the CircleCI failure

@lesteve lesteve force-pushed the run-more-examples branch from e696e68 to cef745b Compare May 11, 2017 17:00
@lesteve lesteve force-pushed the run-more-examples branch from cef745b to fb18955 Compare May 11, 2017 17:01
@lesteve
Copy link
Member Author

lesteve commented May 11, 2017

OK CIs are green, I am going to merge this one.

@lesteve lesteve merged commit 719afba into scikit-learn:master May 11, 2017
@lesteve lesteve deleted the run-more-examples branch May 11, 2017 21:43
@glemaitre
Copy link
Member

@lesteve I'm gonna change the two examples that I mentioned above

@glemaitre glemaitre mentioned this pull request May 11, 2017
Merged
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@lesteve @Sundrique
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
83e6238 
)

Also fix errors and flake8 violations of existing examples
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@lesteve @dmohns
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
c32a87f 
)

Also fix errors and flake8 violations of existing examples
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@lesteve @dmohns
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
1979dc6 
)

Also fix errors and flake8 violations of existing examples
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@lesteve @NelleV
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
1acafe6 
)

Also fix errors and flake8 violations of existing examples
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@lesteve @paulha
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
c5626a6 
)

Also fix errors and flake8 violations of existing examples
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@lesteve @AishwaryaRK
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
ae92d4e 
)

Also fix errors and flake8 violations of existing examples
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@lesteve @maskani-moh
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
c46f092 
)

Also fix errors and flake8 violations of existing examples
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@lesteve
[MRG] Run more examples as part of the doc generation (scikit-learn#8851
a029191 
)

Also fix errors and flake8 violations of existing examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @glemaitre @naoyak