[MRG+1] y not needed in transform in Birch #9066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's also the case for HashingVectorizer, PCA and all classes inheriting from BaseRandomProjection and SparseCodingMixin . Wasn't that about compatibility with the transformers API? |
|
ok this is taken care of now. thx @rth no transform should not have a y. It's not part of the API. see for example : https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/pipeline.py#L315 |
|
all green :) |
|
LGTM. +1 for merge |
|
I think last time we saw this we said "oh let's wait on the API discussions" but I think we can remove this now. |
1 similar comment
|
I think last time we saw this we said "oh let's wait on the API discussions" but I think we can remove this now. |
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* y not needed in transform * y not needed in transform * more
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* y not needed in transform * y not needed in transform * more
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* y not needed in transform * y not needed in transform * more
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
* y not needed in transform * y not needed in transform * more
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* y not needed in transform * y not needed in transform * more
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
* y not needed in transform * y not needed in transform * more
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* y not needed in transform * y not needed in transform * more
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
* y not needed in transform * y not needed in transform * more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Birch had a y in transform method signature