Skip to content

[MRG] MNT Use the default flake8 --ignore options #9123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2017
Merged

[MRG] MNT Use the default flake8 --ignore options #9123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c57a67
Using the default flake8 versions
rth Jun 14, 2017
1a8fee9
Small tweak
lesteve Jun 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions build_tools/travis/flake8_diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,12 @@ check_files() {
if [[ "$MODIFIED_FILES" == "no_match" ]]; then
echo "No file outside sklearn/externals and doc/sphinxext/sphinx_gallery has been modified"
else
check_files "$(echo "$MODIFIED_FILES" | grep -v ^examples)" --ignore=W503
# Default ignore PEP8 violations are from flake8 3.3.0
DEFAULT_IGNORED_PEP8=E121,E123,E126,E226,E24,E704,W503,W504
check_files "$(echo "$MODIFIED_FILES" | grep -v ^examples)" \
--ignore $DEFAULT_IGNORED_PEP8
# Examples are allowed to not have imports at top of file
check_files "$(echo "$MODIFIED_FILES" | grep ^examples)" --ignore=E402,W503
check_files "$(echo "$MODIFIED_FILES" | grep ^examples)" \
--ignore $DEFAULT_IGNORED_PEP8 --ignore E402
fi
echo -e "No problem detected by flake8\n"