[MRG + 1] DOC remove deprecated option in HashingVectorizer examples #9163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashingVectorizer examples
|
I've not checked that this is complete. Otherwise LGTM |
Thanks @jnothman ! I did do a |
|
Check docs while you're at it
…On 20 Jun 2017 8:18 pm, "Roman Yurchak" ***@***.***> wrote:
I've not checked that this is complete. Otherwise LGTM
Thanks @jnothman <https://github.com/jnothman> ! I did do a grep -rn
non_negative examples/ to find all the occurrences..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9163 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6_p79dyVl7lxGxvpxgYjyCS_X_JHks5sF5yBgaJpZM4N-ZFB>
.
|
02bff9e to
c1dd4ef
Compare
|
@jnothman You were right. Also edited a paragraph in the docs to take into account this deprecation.. |
|
LGTM |
amueller
approved these changes
Jun 20, 2017
|
Thanks, |
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…cikit-learn#9163) * DOC remplace non_negative=True with alternate_sign=False in HashingVectorizer examples * Updated feature_extraction doc
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…cikit-learn#9163) * DOC remplace non_negative=True with alternate_sign=False in HashingVectorizer examples * Updated feature_extraction doc
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…cikit-learn#9163) * DOC remplace non_negative=True with alternate_sign=False in HashingVectorizer examples * Updated feature_extraction doc
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…cikit-learn#9163) * DOC remplace non_negative=True with alternate_sign=False in HashingVectorizer examples * Updated feature_extraction doc
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…cikit-learn#9163) * DOC remplace non_negative=True with alternate_sign=False in HashingVectorizer examples * Updated feature_extraction doc
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…cikit-learn#9163) * DOC remplace non_negative=True with alternate_sign=False in HashingVectorizer examples * Updated feature_extraction doc
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…cikit-learn#9163) * DOC remplace non_negative=True with alternate_sign=False in HashingVectorizer examples * Updated feature_extraction doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9152
What does this implement/fix? Explain your changes.
As noticed by @amueller , a few examples are using the
non_negativeparameter of theHashingVectorizereven though it was deprecated in #7565Using
non_negative=False(default), andalternate_sign=Falseshould produce sensibly the same results: positive and with the default hashing table size of ~1e6, the mechanism introduced byalternate_sign=Trueis not necessary: cf #7513 (comment) (the proposed change correponds tonon_negative="total"from that comment).Any other comments?