Skip to content

[RELEASE] 0.18.2 bump version, added whatsnew #9167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2017

Conversation

amueller
Copy link
Member

@amueller amueller commented Jun 19, 2017

Mostly to run the integration ;)

This is the tiniest release ever, mostly to ensure conda forge doesn't need to patch and still works on current numpy.

@amueller amueller changed the title [RELEASE] bump version, added whatsnew [RELEASE] 0.18.2 bump version, added whatsnew Jun 19, 2017
@amueller
Copy link
Member Author

looks like docs are not pushed because stock-market is still failing :-/

@amueller
Copy link
Member Author

I guess the urlopen is not a context on python2?

@jnothman
Copy link
Member

jnothman commented Jun 20, 2017 via email

@amueller
Copy link
Member Author

ok there seems to be another unrelated failure...

@amueller
Copy link
Member Author

sphinx-doc/sphinx#3212 what?

@amueller
Copy link
Member Author

@jakirkham I spent about 3 days on trying to make this release happen and now I'm going away for a week, not sure if anyone will pick it up....

@jakirkham
Copy link
Contributor

Ouch! Sorry to hear that.

On the one hand I'm curious to know what still needs to be done to make this patch release possible as getting scikit-learn built with NumPy 1.13 would be great. However I don't know how helpful I will be as I know much less about the goings on here. On the other hand, assuming things go as planned, there will be a new release of scikit-learn in a couple weeks with NumPy 1.13 support IIUC. Also we had talked about doing an RC or so at conda-forge this go around.

Given all of this, maybe we should just punt on the issue and just start preparing for scikit-learn 0.19.0? What do you think?

@amueller
Copy link
Member Author

I'll try for the next ~1.5 hours that I'll have this week, and then I'll leave it up for the others to decide.
We should definitely do an RC.
The issues I'm mostly running into are related to building the website and CI.

@glemaitre
Copy link
Member

@amueller I am trying to see if I can go somewhere for the next hour with the ci

@amueller
Copy link
Member Author

@glemaitre thanks :)
I have no idea what's happening there :-/ I'm really not bothered by travis, but the website needs to build.

@amueller amueller merged commit 4c65d8e into scikit-learn:0.18.X Jun 20, 2017
@amueller
Copy link
Member Author

Hurray.

@jakirkham
Copy link
Contributor

Thanks @amueller!

@amueller
Copy link
Member Author

@jakirkham I pushed a tag, the wheels are building. So feel free to use the tagged version for conda forge, I think?

@jakirkham
Copy link
Contributor

Great, thanks. Have opened PRs at conda-forge to update scikit-learn based on the tag. Will try and get NumPy 1.13, 1.12, and 1.11 builds of 0.18.2 out in the next day or so.

@amueller
Copy link
Member Author

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants