hopefully fixing circle error #9182
Conversation
|
Just realized this conflicts with #8828. I'm not sure unpinning sphinx is a good idea. Either way seems risky.... |
|
ping @lesteve who apparently just did the opposite. |
|
ping @lesteve who apparently just did the opposite.
He is travelling on vacations. It's unlikely that you get an answer quickly.
|
|
@GaelVaroquaux thanks, not super urgent. |
|
The issue was linked with the building of the PDF. Calling I will give a look if it is the only issue such that the PDF can be built. |
|
As @glemaitre said the pdf doc generation is broken with sphinx 1.6.2 (I was able to reproduce locally too) and I haven't understood why ... they decided to use latexmk in sphinx 1.6 this could be related or a red herring not sure. As far as I understood there is something in the Makefile that is supposed to convert gif into png for inclusion into the LaTeX document but this is not working for some reason. Note: the reason CircleCI is green on this one is that you did not kick off the full doc generation. You need |
|
From #9030 (comment):
This is what broke the build on master for the pdf generation. IIRC we are not running pdf generation on PRs because it would take too much time, hence we did not spot this problem while reviewing the PR. |
|
I pushed 1bb8826 into master which should fix the pdf doc generation on CircleCI. |
|
CircleCI build result can be seen here: https://circleci.com/gh/scikit-learn/scikit-learn/11642. |
|
Though it won't build the PDF there, will it?
…On 26 June 2017 at 22:15, Loïc Estève ***@***.***> wrote:
CircleCI build result can be seen here: https://circleci.com/gh/
scikit-learn/scikit-learn/11642.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9182 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6696sVm70OyvFMv4QwjY4TYigIrhks5sH6DbgaJpZM4N_5O5>
.
|
|
I should since this is in master
…On 26 June 2017 at 14:31, Joel Nothman ***@***.***> wrote:
Though it won't build the PDF there, will it?
On 26 June 2017 at 22:15, Loïc Estève ***@***.***> wrote:
> CircleCI build result can be seen here: https://circleci.com/gh/
> scikit-learn/scikit-learn/11642.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#9182#
issuecomment-311042246>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AAEz6696sVm70OyvFMv4QwjY4TYigIrhks5sH6DbgaJpZM4N_5O5>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9182 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHG9PxO1euAodufCallaMKszAhjimE1eks5sH6SmgaJpZM4N_5O5>
.
--
Guillaume Lemaitre
INRIA Saclay - Parietal team
Center for Data Science Paris-Saclay
https://glemaitre.github.io/
|
CircleCI just finished and is green so I am going to close this one. |
|
Oh, I missed that. It worked! Thanks!
On 26 June 2017 at 22:38, Guillaume Lemaitre <notifications@github.com>
wrote:
… I should since this is in master
On 26 June 2017 at 14:31, Joel Nothman ***@***.***> wrote:
> Though it won't build the PDF there, will it?
>
> On 26 June 2017 at 22:15, Loïc Estève ***@***.***> wrote:
>
> > CircleCI build result can be seen here: https://circleci.com/gh/
> > scikit-learn/scikit-learn/11642.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <#9182#
> issuecomment-311042246>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/
> AAEz6696sVm70OyvFMv4QwjY4TYigIrhks5sH6DbgaJpZM4N_5O5>
>
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#9182#
issuecomment-311045509>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
AHG9PxO1euAodufCallaMKszAhjimE1eks5sH6SmgaJpZM4N_5O5>
> .
>
--
Guillaume Lemaitre
INRIA Saclay - Parietal team
Center for Data Science Paris-Saclay
https://glemaitre.github.io/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9182 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6704jDUzVIf-vFEyMfNOdMTU7KSaks5sH6ZNgaJpZM4N_5O5>
.
|
|
For completeness, a summary of the problem:
|
Tries to fix the circle failure caused by sphinx-doc/sphinx#3212