[MRG+1] MAINT Upgrade to sphinx 1.6.2 #9227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lesteve stupid me, we don't run latex on PR, but locally it built for me. |
jnothman
reviewed
Jun 26, 2017
| @@ -566,20 +565,14 @@ def reduced_likelihood_function(self, theta=None): | |||
| A dictionary containing the requested Gaussian Process model | |||
| parameters: | |||
|
|
|||
| sigma2 | |||
There was a problem hiding this comment.
Apart from being over indented what's the problem here? Isn't this otherwise a valid rst definition list?
There was a problem hiding this comment.
I'll check a bit more but the bottom line is that it leads to a "too deeply nested" error.
sklearn/preprocessing/label.py
Outdated
|
|
||
| If None, the threshold is assumed to be half way between | ||
| neg_label and pos_label. | ||
| Threshold used in the binary and multi-label cases. Use 0 when, |
| @@ -539,8 +539,7 @@ def predict(self, X, eval_MSE=False, batch_size=None): | |||
| return y | |||
|
|
|||
| def reduced_likelihood_function(self, theta=None): | |||
| """ | |||
| This function determines the BLUP parameters and evaluates the reduced | |||
| """This function determines the BLUP parameters and evaluates the reduced | |||
There was a problem hiding this comment.
This should really be a single line summary.
There was a problem hiding this comment.
Sorry emacs auto-saving
doc/about.rst
Outdated
| @@ -169,13 +167,13 @@ for code sprints, as well as towards the organization budget of the project [#f1 | |||
| <input type="hidden" name="cmd" value="_s-xclick"> | |||
| <input type="hidden" name="hosted_button_id" value="74EYUMF3FTSW8"> | |||
| <input type="image" | |||
| src="https://www.paypalobjects.com/en_US/i/btn/btn_donateCC_LG.gif" | |||
| src="http://www.pngall.com/wp-content/uploads/2016/05/PayPal-Donate-Button-High-Quality-PNG.png" | |||
There was a problem hiding this comment.
Not necessary to chance for latex. It won't render this html
|
LGTM. |
|
you can force latex builds with the right commit message iirc. |
amueller
reviewed
Jun 28, 2017
| @@ -105,7 +107,7 @@ conda update --yes --quiet conda | |||
| # Configure the conda environment and put it in the path using the | |||
| # provided versions | |||
| conda create -n $CONDA_ENV_NAME --yes --quiet python numpy scipy \ | |||
| cython nose coverage matplotlib sphinx=1.5 pillow | |||
There was a problem hiding this comment.
do we not want to pin it to 1.6.2?
|
lgtm though I might sleep better if it's pinned. |
|
Thanks a lot for debugging this! Merging. |
midinas
pushed a commit
to midinas/scikit-learn
that referenced
this pull request
Jun 29, 2017
midinas
pushed a commit
to midinas/scikit-learn
that referenced
this pull request
Jun 29, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lesteve I upgraded to sphinx 1.6.2, I replaced the
gifby some equivalentpngand solve the latex error due totoo deep nestedstuff.hope it will turn green