[MRG + 1] Fix wrong error message in StratifiedKFold #9396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do I rebuild AppVeyor? |
|
Don't worry about it. |
jnothman
reviewed
Jul 18, 2017
| raise ValueError("All the n_groups for individual classes" | ||
| " are less than n_splits=%d." | ||
| raise ValueError("n_splits=%d cannot be greater than the" | ||
| " number of members in each class." | ||
| % (self.n_splits)) | ||
| if self.n_splits > min_groups: | ||
| warnings.warn(("The least populated class in y has only %d" |
There was a problem hiding this comment.
please fix the word groups below too
|
lgtm |
amueller
approved these changes
Jul 18, 2017
|
Thanks @bmanohar16 |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
* Fix wrong error message in StratifiedKFold * Remove groups in warning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9381
What does this implement/fix? Explain your changes.
Fixes wrong error message used while creating folds in StratifiedKFold
Any other comments?
None