[MRG+1] Minor fix on the _grid_from_X function #9434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
|
LGTM. Less surprising this way and I don't expect this to be a bottleneck in terms of performance. |
|
thanks :) |
trevorstephens
added a commit
to trevorstephens/scikit-learn
that referenced
this pull request
Jul 26, 2017
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
trevorstephens
added a commit
to trevorstephens/scikit-learn
that referenced
this pull request
Aug 12, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Minor fix on the _grid_from_X function. The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop
trevorstephens
added a commit
to trevorstephens/scikit-learn
that referenced
this pull request
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emp_percentiles variable is computed in the loop but not does not actually change, so it should be pulled out of the loop.