Skip to content

[MRG] DOC use def instead of lambda in the multimetric example at model_evaluation.rst #9442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

raghavrv
Copy link
Member

This was one of the pending comments at #7388

@jnothman (Raising this as a separate PR to avoid noise at #9326)

@raghavrv raghavrv force-pushed the multimetric_part3 branch from b8a21b6 to 970a513 Compare July 24, 2017 12:15
@raghavrv raghavrv force-pushed the multimetric_part3 branch from 970a513 to c08887e Compare July 24, 2017 12:17
@jnothman
Copy link
Member

LGTM

@jnothman jnothman changed the title [MRG] DOC use def instead of lambda in the multimetric example at model_evaluation.rst [MRG+1] DOC use def instead of lambda in the multimetric example at model_evaluation.rst Jul 24, 2017
@amueller
Copy link
Member

missing return statement -> test failure

@amueller
Copy link
Member

So pytest currently doesn't run the doctests? hm...

@jnothman
Copy link
Member

Whoops. I was a bit fast on the LGTM

@jnothman
Copy link
Member

Setup.cfg should be enabling doctests as far as I can see. But pytest doesn't seem to give any visual feedback to say that the doctests are enabled.

@TomDLT TomDLT changed the title [MRG+1] DOC use def instead of lambda in the multimetric example at model_evaluation.rst [MRG] DOC use def instead of lambda in the multimetric example at model_evaluation.rst Jul 25, 2017
@lesteve
Copy link
Member

lesteve commented Jul 26, 2017

LGTM, merging thanks!

@lesteve lesteve merged commit 02a31f0 into scikit-learn:master Jul 26, 2017
@raghavrv raghavrv deleted the multimetric_part3 branch July 26, 2017 11:45
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Aug 6, 2017
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants