[MRG+1] FIX Add missing mixins to ClassifierChain #9473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomDLT
reviewed
Aug 3, 2017
| @@ -380,6 +381,8 @@ def test_classifier_chain_fit_and_predict_with_logistic_regression(): | |||
| assert_equal([c.coef_.size for c in classifier_chain.estimators_], | |||
| list(range(X.shape[1], X.shape[1] + Y.shape[1]))) | |||
|
|
|||
| assert isinstance(classifier_chain, ClassifierMixin) | |||
There was a problem hiding this comment.
In light of #9475, you should probably use is_classifier
There was a problem hiding this comment.
Not in a test assertion. The point here is that it also ensures a default implementation is score
|
Hm maybe this kind of issue could be avoided with the estimator tags to check that tags are complete? hm... |
|
It can also be avoided by raising a warning and later an error in
ClassifierMixin.__subclasscheck__!
…On 5 August 2017 at 02:27, Andreas Mueller ***@***.***> wrote:
Hm maybe this kind of issue could be avoided with the estimator tags to
check that tags are complete? hm...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9473 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz69iJWP25jy38g3yRRS-Ay_HCfQ-Lks5sU0ZsgaJpZM4Oqb7p>
.
|
jnothman
added a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
* Add missing mixins to ClassifierChain * Fix import in test
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Add missing mixins to ClassifierChain * Fix import in test
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
* Add missing mixins to ClassifierChain * Fix import in test
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Aug 12, 2017
Release 0.19.0 * tag '0.19.0': (99 commits) DOC one more version issue in doc skip docstring tests because not useful to users and has some issues deprecation of n_components happened in 0.19 not 0.18 (scikit-learn#9527) sync whatsnew with master so I'm less confused DOC more navigation links DOC a note on data leakage and pipeline (scikit-learn#9510) DOC set release date to Friday DOC Update news and menu for 0.19 release DOC list of contributors to 0.19 DOC Change release date to Thursday DOC Remove some whitespace from what's new Update what's new for recent changes Use base.is_classifier instead instead of isinstance (scikit-learn#9482) Fix safe_indexing with read-only indices (scikit-learn#9507) [MRG+1] add scorer based on explained_variance_score (scikit-learn#9259) fix wrong assert in test_validation (scikit-learn#9480) [MRG+1] FIX Add missing mixins to ClassifierChain (scikit-learn#9473) Bring last code block in line with the image. (scikit-learn#9488) FIX Pass sample_weight as kwargs in VotingClassifier (scikit-learn#9493) FIX Incorrent implementation of noise_variance_ in PCA._fit_truncated (scikit-learn#9108) ...
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Aug 12, 2017
* releases: (99 commits) DOC one more version issue in doc skip docstring tests because not useful to users and has some issues deprecation of n_components happened in 0.19 not 0.18 (scikit-learn#9527) sync whatsnew with master so I'm less confused DOC more navigation links DOC a note on data leakage and pipeline (scikit-learn#9510) DOC set release date to Friday DOC Update news and menu for 0.19 release DOC list of contributors to 0.19 DOC Change release date to Thursday DOC Remove some whitespace from what's new Update what's new for recent changes Use base.is_classifier instead instead of isinstance (scikit-learn#9482) Fix safe_indexing with read-only indices (scikit-learn#9507) [MRG+1] add scorer based on explained_variance_score (scikit-learn#9259) fix wrong assert in test_validation (scikit-learn#9480) [MRG+1] FIX Add missing mixins to ClassifierChain (scikit-learn#9473) Bring last code block in line with the image. (scikit-learn#9488) FIX Pass sample_weight as kwargs in VotingClassifier (scikit-learn#9493) FIX Incorrent implementation of noise_variance_ in PCA._fit_truncated (scikit-learn#9108) ...
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Aug 12, 2017
* dfsg: (99 commits) DOC one more version issue in doc skip docstring tests because not useful to users and has some issues deprecation of n_components happened in 0.19 not 0.18 (scikit-learn#9527) sync whatsnew with master so I'm less confused DOC more navigation links DOC a note on data leakage and pipeline (scikit-learn#9510) DOC set release date to Friday DOC Update news and menu for 0.19 release DOC list of contributors to 0.19 DOC Change release date to Thursday DOC Remove some whitespace from what's new Update what's new for recent changes Use base.is_classifier instead instead of isinstance (scikit-learn#9482) Fix safe_indexing with read-only indices (scikit-learn#9507) [MRG+1] add scorer based on explained_variance_score (scikit-learn#9259) fix wrong assert in test_validation (scikit-learn#9480) [MRG+1] FIX Add missing mixins to ClassifierChain (scikit-learn#9473) Bring last code block in line with the image. (scikit-learn#9488) FIX Pass sample_weight as kwargs in VotingClassifier (scikit-learn#9493) FIX Incorrent implementation of noise_variance_ in PCA._fit_truncated (scikit-learn#9108) ...
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Add missing mixins to ClassifierChain * Fix import in test
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
* Add missing mixins to ClassifierChain * Fix import in test
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Add missing mixins to ClassifierChain * Fix import in test
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
* Add missing mixins to ClassifierChain * Fix import in test
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These shouldn't have been missing...