[MRG+1] Remove hard dependency on nose #9670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad12049 to
c08f128
Compare
c08f128 to
6d084d9
Compare
massich
commented
Sep 1, 2017
| @@ -754,10 +765,6 @@ def __exit__(self, exc_type, exc_val, exc_tb): | |||
| _delete_folder(self.temp_folder) | |||
|
|
|||
|
|
|||
| with_network = with_setup(check_skip_network) | |||
There was a problem hiding this comment.
We removed those two aliases since they were meant for the CI and they are used nowhere in the codebase.
There was a problem hiding this comment.
It is also very unlikely that they are used in any downstream projects.
|
Hmmm the AppVeyor failures look genuine. And actually failures can be seen on Travis as well. |
6d084d9 to
10e4202
Compare
which depends on nose and replace with sklearn.utils.testing.assert_raises
|
With the last commit, the pytest build on Travis does not have nose installed so that will ensure that we don't have a nose dependency any more. @jnothman any opinions on this PR? |
jnothman
reviewed
Sep 6, 2017
sklearn/utils/testing.py
Outdated
| 'If your code relies on with_setup, please use' | ||
| ' nose.tools.with_setup instead.') | ||
| with_setup = deprecated(deprecation_message)(_with_setup) | ||
| additional_symbols_to_export = ['raises', 'with_setup'] |
There was a problem hiding this comment.
What's the story with raises?
Not sure what you mean.
There was a problem hiding this comment.
Ahh now I see it deprecated above. No worries
|
lgtm if tests pass |
|
@amueller It is green. LGTM |
|
Thanks @massich |
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Sep 12, 2017
massich
added a commit
to massich/scikit-learn
that referenced
this pull request
Sep 15, 2017
amueller
added a commit
to amueller/scikit-learn
that referenced
this pull request
Sep 19, 2017
remove outdated comment fix also for FeatureUnion [MRG+2] Limiting n_components by both n_features and n_samples instead of just n_features (Recreated PR) (scikit-learn#8742) [MRG+1] Remove hard dependency on nose (scikit-learn#9670) MAINT Stop vendoring sphinx-gallery (scikit-learn#9403) CI upgrade travis to run on new numpy release (scikit-learn#9096) CI Make it possible to run doctests in .rst files with pytest (scikit-learn#9697) * doc/datasets/conftest.py to implement the equivalent of nose fixtures * add conftest.py in root folder to ensure that sklearn local folder is used rather than the package in site-packages * test doc with pytest in Travis * move custom_data_home definition from nose fixture to .rst file [MRG+1] avoid integer overflow by using floats for matthews_corrcoef (scikit-learn#9693) * Fix bug#9622: avoid integer overflow by using floats for matthews_corrcoef * matthews_corrcoef: cosmetic change requested by jnothman * Add test_matthews_corrcoef_overflow for Bug#9622 * test_matthews_corrcoef_overflow: clean-up and make deterministic * matthews_corrcoef: pass dtype=np.float64 to sum & trace instead of using astype * test_matthews_corrcoef_overflow: add simple deterministic tests TST Platform independent hash collision tests in FeatureHasher (scikit-learn#9710) TST More informative error message in test_preserve_trustworthiness_approximately (scikit-learn#9738) add some rudimentary tests for meta-estimators fix extra whitespace in error message add missing if_delegate_has_method in pipeline don't test tuple pipeline for now only copy list if not list already? doesn't seem to help?
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
None
What does this implement/fix? Explain your changes.
It removes
with_setupand adds a deprecation in order to removenosedepencieAny other comments?
This PR removes the dependency on nose from our python modules.