[MRG+1] Fix #9676: Section level wrong in user guide #9679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.1.3 and 3.1.4 changed to 3.1.2.1 and 3.1.2.2
|
Visual PR changes -
|
|
Firstly, I don't think you should be moving anything. Secondly, to me it's not this simple. Everything from the current 3.1.3 to 3.1.8 should be within 3.1.2. So every heading in that passage needs to be the next level. |
|
Hi @jnothman, thanks for your review. I pushed a commit. Made all the headings from 3.1.3 - 3.1.8 under 3.1.2. PTAL. Thanks! |
|
LGTM. +1 for merge. |
|
Here is an excerpt of the htmldiff:
I am wondering whether "A note on shuffling" and "Cross validation and model selection" should not be on the same level as "Cross validation iterators" |
|
that would probably be neater, if less strictly logical...
…On 4 Sep 2017 6:35 pm, "Loïc Estève" ***@***.***> wrote:
Here is an excerpt of the htmldiff:
[image: snapshot]
<https://user-images.githubusercontent.com/1680079/30018148-11a54e6a-915c-11e7-96f6-551fc8cfa678.png>
I am wondering whether "A note on shuffling" and "Cross validation and
model selection" should not be on the same level as "Cross validation
iterators"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9679 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6yoMAYaKlZtdWLl4IzjCGH81xJ27ks5se7ZBgaJpZM4PLMT->
.
|
|
Is it good to merge or do I have to unindent - "A note on shuffling" and "Cross validation and model selection"? |
|
I think @lesteve may be right, that we don't lose anything by making Cross Validation Iterators a top level heading here... |
|
I pushed the change I had in mind, merging this one, thanks a lot @shaz13! |
|
@lesteve have you checked the rendering of that change?
…On 4 September 2017 at 23:31, Loïc Estève ***@***.***> wrote:
Merged #9679 <#9679>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9679 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz60laxIKZiEBPvsp7xl_jNZGHT5Meks5se_u_gaJpZM4PLMT->
.
|
|
In my head I did ;-). Basically I wanted "A note on shuffling" and "Cross validation and model selection" to have the same level as "Cross Validation iterators". Seems fine AFAICT from: |
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Sep 15, 2017
amueller
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Oct 20, 2017
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Oct 24, 2017
* tag '0.19.1': (117 commits) TST Improve SelectFromModel tests (scikit-learn#9733) Name in what's new [MRG+1] Raise error when SparseSeries is passed into classification metrics (scikit-learn#7373) Fix LogisticRegressionCV default solver value in docstring (scikit-learn#9962) [MRG+1] DOC fix sign in GBRT mathematical formulation (scikit-learn#9885) [MRG+1] DOC fix sign in GBRT mathematical formulation (scikit-learn#9885) DOC fix a typo (scikit-learn#9892) [MRG+1] Ledoit-Wolf behavior explanation (scikit-learn#9500) [MRG+1] Fix typos in documentation (scikit-learn#9878) DOC: Use setattr(self, ...) instead of self.setattr(...) (scikit-learn#9866) DOC Removed a duplicate occurrence of a word in 'sklearn.neighbors.KNeighborsRegressor' docs (scikit-learn#9862) FIX docstring of negative_outlier_factor_ in LOF (scikit-learn#9809) [MRG+1] Fix scikit-learn#9743: Adding parameter information to docstring. (scikit-learn#9757) DOC: fix docstring of Imputer.fit (scikit-learn#9769) various minor spelling tweaks (scikit-learn#9783) MAINT comment on apparent inconsistency [MRG+1] DOC fix headers level in cross_validation.rst (scikit-learn#9679) Fix mailmap format (scikit-learn#9620) DOC Fix typos (scikit-learn#9577) Typo (scikit-learn#9571) ...
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Oct 24, 2017
* releases: (117 commits) TST Improve SelectFromModel tests (scikit-learn#9733) Name in what's new [MRG+1] Raise error when SparseSeries is passed into classification metrics (scikit-learn#7373) Fix LogisticRegressionCV default solver value in docstring (scikit-learn#9962) [MRG+1] DOC fix sign in GBRT mathematical formulation (scikit-learn#9885) [MRG+1] DOC fix sign in GBRT mathematical formulation (scikit-learn#9885) DOC fix a typo (scikit-learn#9892) [MRG+1] Ledoit-Wolf behavior explanation (scikit-learn#9500) [MRG+1] Fix typos in documentation (scikit-learn#9878) DOC: Use setattr(self, ...) instead of self.setattr(...) (scikit-learn#9866) DOC Removed a duplicate occurrence of a word in 'sklearn.neighbors.KNeighborsRegressor' docs (scikit-learn#9862) FIX docstring of negative_outlier_factor_ in LOF (scikit-learn#9809) [MRG+1] Fix scikit-learn#9743: Adding parameter information to docstring. (scikit-learn#9757) DOC: fix docstring of Imputer.fit (scikit-learn#9769) various minor spelling tweaks (scikit-learn#9783) MAINT comment on apparent inconsistency [MRG+1] DOC fix headers level in cross_validation.rst (scikit-learn#9679) Fix mailmap format (scikit-learn#9620) DOC Fix typos (scikit-learn#9577) Typo (scikit-learn#9571) ...
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Oct 24, 2017
* dfsg: (117 commits) TST Improve SelectFromModel tests (scikit-learn#9733) Name in what's new [MRG+1] Raise error when SparseSeries is passed into classification metrics (scikit-learn#7373) Fix LogisticRegressionCV default solver value in docstring (scikit-learn#9962) [MRG+1] DOC fix sign in GBRT mathematical formulation (scikit-learn#9885) [MRG+1] DOC fix sign in GBRT mathematical formulation (scikit-learn#9885) DOC fix a typo (scikit-learn#9892) [MRG+1] Ledoit-Wolf behavior explanation (scikit-learn#9500) [MRG+1] Fix typos in documentation (scikit-learn#9878) DOC: Use setattr(self, ...) instead of self.setattr(...) (scikit-learn#9866) DOC Removed a duplicate occurrence of a word in 'sklearn.neighbors.KNeighborsRegressor' docs (scikit-learn#9862) FIX docstring of negative_outlier_factor_ in LOF (scikit-learn#9809) [MRG+1] Fix scikit-learn#9743: Adding parameter information to docstring. (scikit-learn#9757) DOC: fix docstring of Imputer.fit (scikit-learn#9769) various minor spelling tweaks (scikit-learn#9783) MAINT comment on apparent inconsistency [MRG+1] DOC fix headers level in cross_validation.rst (scikit-learn#9679) Fix mailmap format (scikit-learn#9620) DOC Fix typos (scikit-learn#9577) Typo (scikit-learn#9571) ...
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9676
The Section level is now reordered as suggested in the issue. Thanks @GaelVaroquaux !