[MRG] Addresses test errors on numpy-dev #9683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this WIP?
…On 4 September 2017 at 08:00, Kumar Ashutosh ***@***.***> wrote:
Reference Issue
Fixes #9673 <#9673>
What does this implement/fix? Explain your changes.
Changed the second parameters of issubdtype so as to avoid deprecation
warning.
Any other comments?
The warning in /home/travis/testvenv/lib/python3.5/site-packages/scipy/
sparse/csgraph/_laplacian.py still occurs.
------------------------------
You can view, comment on, or merge this pull request online at:
#9683
Commit Summary
- Fixes deprecation warning
File Changes
- *M* sklearn/ensemble/gradient_boosting.py
<https://github.com/scikit-learn/scikit-learn/pull/9683/files#diff-0>
(2)
- *M* sklearn/feature_extraction/text.py
<https://github.com/scikit-learn/scikit-learn/pull/9683/files#diff-1>
(2)
- *M* sklearn/learning_curve.py
<https://github.com/scikit-learn/scikit-learn/pull/9683/files#diff-2>
(2)
- *M* sklearn/model_selection/_validation.py
<https://github.com/scikit-learn/scikit-learn/pull/9683/files#diff-3>
(2)
- *M* sklearn/utils/__init__.py
<https://github.com/scikit-learn/scikit-learn/pull/9683/files#diff-4>
(2)
Patch Links:
- https://github.com/scikit-learn/scikit-learn/pull/9683.patch
- https://github.com/scikit-learn/scikit-learn/pull/9683.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9683>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAEz619OaLg8iWsntWMqK1qLHowvl2rvks5seyGSgaJpZM4PLUQA>
.
|
|
The deprecation warning stills shows up in |
|
Ah, I see your comment now. Thanks.
…On 4 September 2017 at 12:06, Kumar Ashutosh ***@***.***> wrote:
The deprecation warning stills shows up in home/travis/testvenv/lib/
python3.5/site-packages/scipy/sparse/csgraph/_laplacian.py. I thought
this also needs to be addressed. :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz6xKjtS6RAaG5AyoaWNNbKRAUGQkbks5se1sPgaJpZM4PLUQA>
.
|
|
Any suggestions on how I can address this issue? |
|
Oh, no, I see the code is fixed in scipy master. Let me look at what travis is doing. |
|
Yeah, so this looks like an issue with our travis config: the scipy version
there was last updated 21 July.
…On 4 September 2017 at 12:11, Kumar Ashutosh ***@***.***> wrote:
Any suggestions on how I can address this issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz68xwm2rMxZSIT4l6zcAqopneQw3nks5se1w6gaJpZM4PLUQA>
.
|
|
Yaa, so I guess this PR is fine once Travis is updated. |
|
@matthew-brett, any idea why the scipy wheels have not been published for
platforms other than Windows at
https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com
?
…On 4 September 2017 at 12:20, Kumar Ashutosh ***@***.***> wrote:
Yaa, so I guess this PR is fine once Travis is updated.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz63d1Twvn1Mbd6KmbMxi15tjOQV_Aks5se15ggaJpZM4PLUQA>
.
|
|
since July 21, I should say...
…On 4 September 2017 at 12:22, Joel Nothman ***@***.***> wrote:
@matthew-brett, any idea why the scipy wheels have not been published for
platforms other than Windows at https://7933911d6844c6c53a7d-
47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com?
On 4 September 2017 at 12:20, Kumar Ashutosh ***@***.***>
wrote:
> Yaa, so I guess this PR is fine once Travis is updated.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#9683 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAEz63d1Twvn1Mbd6KmbMxi15tjOQV_Aks5se15ggaJpZM4PLUQA>
> .
>
|
|
LGTM, thanks a lot @thechargedneutron, merging! |
|
@lesteve welcome :) |
|
@jnothman - thanks for checking the wheels. The current pre-release Rackspace container is at https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com - does that work for you? EDIT: sorry - I should say that I do see recent scipy wheels at that location. Not true for you? |
This is the URL we are using.
From what I can see the last scipy manylinux wheel is from July 23rd, the last scipy windows wheel is from September 3rd. |
|
Aha, yes - sorry - you're right. I had just fixed that, new wheels should appear soon. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 4, 2017
|
Thanks a lot! |
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Sep 15, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #9673
What does this implement/fix? Explain your changes.
Changed the second parameters of
issubdtypeso as to avoid deprecation warning.Any other comments?
The warning in
/home/travis/testvenv/lib/python3.5/site-packages/scipy/sparse/csgraph/_laplacian.pystill occurs.