Skip to content

Update california_housing.py #9821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update california_housing.py #9821

wants to merge 1 commit into from

Conversation

lucianocrt
Copy link

fixing issue #9820 by closing the tar file before trying to remove it

Reference Issue

Fixes #9820

What does this implement/fix? Explain your changes.

closes the tar file before trying to remove it

Any other comments?

jnothman
jnothman reviewed Sep 24, 2017
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a try/finally block just to be sure that the file is closed and path removed even if an error occurs in the process? This would be best practice...

@qinhanmin2014 qinhanmin2014 mentioned this pull request Oct 18, 2017
Closed
@lesteve lesteve closed this Oct 18, 2017
@lesteve
Copy link
Member

lesteve commented Oct 18, 2017

Closed by #9847.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] PermissionError in datasets fetchers when trying to remove the downloaded archive
3 participants
@lucianocrt @lesteve @jnothman