[MRG+1] Travis: move scipy-dev-wheels build to a cron job #9852
Conversation
e41bc8e to
b00a14d
Compare
scipy-dev-wheels build not allowed to fail anymore. Do not run doctests in scipy-dev build because they are broken on numpy dev due to a change in the numpy array repr/str with spaces.
b00a14d to
b10192f
Compare
build_tools/travis/test_script.sh
Outdated
| if [[ "$DISTRIB" == "scipy-dev-wheels" ]]; then | ||
| # Do not run doctests in scipy-dev-wheels build for now | ||
| # (broken by numpy 1.14.dev array repr/str formatting change) | ||
| export PYTEST_ADDOPTS="-p no:doctest" |
There was a problem hiding this comment.
I'd rather modify TEST_CMD than mix local and global env changes.
There was a problem hiding this comment.
I ended up using np.set_printoptions(sign='legacy') in conftest.py. This way, the Travis test_script.sh code is simpler and it works locally for people using numpy > 1.13.
|
I am going to merge this one and enable a Travis cron job on the master branch. |
|
This is pretty cool. When were cron jobs introduced and how are they configured? I don't see the frequency in the code. |
|
I think they were introduced a while ago (maybe months) but what is new is the fact that you can have a dynamical build matrix (the cron job has only scipy-dev-wheels build and the "normal" build has all the builds). The latter is more recent: The cron job has to be configured in https://travis-ci.org/scikit-learn/scikit-learn/settings (branch name and frequency which can be daily, weekly or monthly) |
The plan is to use a daily cron job to test the development numpy and scipy wheels. The idea behind this is that it is very rare that a particular numpy-dev or scipy-dev related failure is due to a change in the PR.
The cron job will be daily and the numpy-dev scipy-dev will not be allowed to fail. I think it fails quite rarely and allow_failures means we tend not to pay enough attention to failures. Also because it only runs daily it does not mean that many emails in case of failure.
I am skipping doctests in scipy-dev build because they are broken on numpy dev due to a change in the numpy array repr/str with spaces. Note I switched to pytest for the scipy-dev build, mostly because it is easier to skip doctests.
I have tested the cron job and the .travis.yml on lesteve/scikit-learn in Travis and everything works. I'll wait to see if anyone has comments/concerns and if not I'll merge this one.
More details about the numpy array repr/str changes
1.13.1:
1.14dev:
Part of the gory details: numpy/numpy#9139.