-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[MRG+1] Add Normalized Discounted Cumulative Gain #9951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
4f70065
add DCG and NDCG
jeromedockes 0e06a80
add wikipedia links for ndcg
jeromedockes 3542fcd
missing blank line
jeromedockes 7e5190e
fix ndcg test
jeromedockes f78f8cb
undo unrelated change to metrics/__init__.py
jeromedockes 776ed36
improve dcg and ndcg docstrings
jeromedockes 17ca372
use check_array and check_consistent_length
jeromedockes dbf3826
add dcg and ndcg to test_common thresholded metrics
jeromedockes f9d741f
backport np.unique with return_counts in sklearn.utils.fixes
johny-c 140a682
add a test function in utils.tests.test_fixes.py
johny-c ad71190
change link to correct numpy commit
johny-c c3552f0
unused import
jeromedockes ca48505
remove references in private functions' docstrings
jeromedockes 560ccd3
add test dcg and ndcg on toy examples
jeromedockes d68ee1a
add examples to ndcg_score and dcg_score docstrings
jeromedockes aa4bd9c
fix ndcg_score doctests
jeromedockes e6c2c01
average ties in ndcg
jeromedockes 1bc867e
faster dcg tie averaging
jeromedockes f395ba0
Merge branch 'master' into add_ndcg
jeromedockes 15bbb4f
add test dcg ties
jeromedockes 934969e
Merge remote-tracking branch 'johny_c/backport-np-unique' into add_ndcg
jeromedockes cfc2309
use backport for unique with return_counts
jeromedockes 5d0b9a6
test ndcg invariant if order preserved
jeromedockes abd579f
check translation invariant
jeromedockes 2bb30b2
add reference for tied ndcg
jeromedockes a9d8368
add narrative doc for ndcg
jeromedockes fb0b667
Merge branch 'master' into add_ndcg
jeromedockes 2c996e9
improve ndcg documentation
jeromedockes 09cf1b5
plain assert instead of assert_true in ndcg tests
jeromedockes df1df69
Merge branch 'master' into add_ndcg
jeromedockes 4517f06
move checks to public dcg/ndcg functions
jeromedockes 97677ee
fix key error in metrics/test_common.py
jeromedockes f908fef
check target type in ndcg (not only dcg)
jeromedockes 981783c
add ignore_ties option to dcg and ndcg for performance
jeromedockes af81310
improve examples in dcg and ndcg docstrings
jeromedockes 5bf100a
Merge remote-tracking branch 'upstream/master' into add_ndcg
jeromedockes 6059a7c
docstring details
jeromedockes c545c63
unused variable
jeromedockes d865cea
add ndcg to whatsnew
jeromedockes 75f4515
Merge branch 'master' into add_ndcg
jeromedockes 9ba639b
Merge branch 'master' into add_ndcg
jeromedockes 66f63a3
more details about DCG in documentation
jeromedockes 371ab30
Merge remote-tracking branch 'upstream/master' into add_ndcg
jeromedockes fc36f39
flake8 ignore unused import in fixes
jeromedockes c894380
address https://github.com/scikit-learn/scikit-learn/pull/9951#discus…
jeromedockes 988546b
remove examples with perfect prediction from dcg docstrings
jeromedockes 306cb88
more details in ndcg docs + comparison with ranking loss
jeromedockes 1feef33
remove np.unique from utils.fixes
jeromedockes 5d3c5a6
Merge remote-tracking branch 'upstream/master' into add_ndcg
jeromedockes ea0f545
remove tests made obsolete by numpy version bump
jeromedockes b396471
Merge remote-tracking branch 'upstream/master' into add_ndcg
jeromedockes e77eb64
Merge remote-tracking branch 'upstream/master' into add_ndcg
jeromedockes b763abe
update whatsnew
jeromedockes c7e2c19
Merge remote-tracking branch 'upstream/master' into add_ndcg
jeromedockes 81ac36c
Merge remote-tracking branch 'upstream/master' into add_ndcg
jeromedockes ba2c07c
address comments on doc
jeromedockes 96233cb
revert change unrelated to NDCG
jeromedockes 67f4dc3
add docstring for _tie_averaged_dcg
jeromedockes 00c2d2a
log_basis -> log_base
jeromedockes 450065c
performance -> efficiency
jeromedockes 11574ce
comment about ignoring ties when computing normalization in ndcg
jeromedockes ccc0875
np.zeros -> np.empty
jeromedockes 3d4f2cc
parametrize test_ndcg_toy_examples with ignore_ties
jeromedockes cb8a6b4
check same results with k and ignore_ties in the absence of ties
jeromedockes 3d6d286
pep8
jeromedockes 24413d8
Merge branch 'master' into add_ndcg
glemaitre 0cafb21
Merge remote-tracking branch 'origin/master' into add_ndcg
glemaitre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.