Skip to content

[MRG] class design for AgglomerativeClustering and FeatureAgglomeration #9846 #9984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MRG] class design for AgglomerativeClustering and FeatureAgglomeration #9846 #9984

wants to merge 1 commit into from

Conversation

dkmehrmann
Copy link

Fixes #9846. I noticed too late that this is already being worked on in #9875 so feel free to reject and close.

@jnothman
Copy link
Member

Thanks for the PR. Please take a look at #9875 where you'll see how this actually looks in the end. Sorry for leaving the original marked help wanted.

@jnothman jnothman closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve class design for AgglomerativeClustering and FeatureAgglomeration (was pooling_func in AgglomerativeClustering doesn't work)
2 participants
@dkmehrmann @jnothman