MTN: refacto Risk Control API #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Refactors the multi-label conformal prediction API by renaming the MapieMultiLabelClassifier to PrecisionRecallController and updating all related imports, references, tests, examples, and documentation.
- Renamed class and updated return type hints in
mapie/risk_control.py - Updated imports and usages in notebooks, tests, examples, and docs
- Adjusted module exports in
mapie/__init__.pyand updated API docs
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| notebooks/classification/tutorial_multilabel_classification_recall.ipynb | Updated import, markdown, and code to use PrecisionRecallController |
| notebooks/classification/tutorial_multilabel_classification_precision.ipynb | Same renaming in precision tutorial |
| mapie/tests/test_multi_label_classification.py | Replaced MapieMultiLabelClassifier references with PrecisionRecallController in tests |
| mapie/risk_control.py | Renamed class and adjusted docstring examples and return types |
| mapie/control_risk/risks.py | Updated comments referencing old class name |
| mapie/init.py | Swapped out multi_label_classification export for risk_control |
| examples/multilabel_classification/1-quickstart/plot_tutorial_multilabel_classification.py | Updated example script to import and use new class |
| doc/api.rst | Updated API listing to reference PrecisionRecallController |
Comments suppressed due to low confidence (1)
mapie/init.py:5
- [nitpick] Removing the
multi_label_classificationmodule export is a breaking change; consider providing a deprecated alias or migration path for users upgrading from previous versions.
multi_label_classification,
| "\n", | ||
| "MapieMultiLabelClassifier will be fitted with RCPS and CRC methods. For the RCPS method, we will test all three Upper Confiance Bound (Hoeffding, Bernstein and Waudby-Smith–Ramdas).\n", | ||
| "PrecisionRecallController will be fitted with RCPS and CRC methods. For the RCPS method, we will test all three Upper Confiance Bound (Hoeffding, Bernstein and Waudby-Smith–Ramdas).\n", |
There was a problem hiding this comment.
The word “Confiance” is misspelled; please change to “Confidence” (and consider pluralizing to “Bounds”).
Suggested change
| "PrecisionRecallController will be fitted with RCPS and CRC methods. For the RCPS method, we will test all three Upper Confiance Bound (Hoeffding, Bernstein and Waudby-Smith–Ramdas).\n", | |
| "PrecisionRecallController will be fitted with RCPS and CRC methods. For the RCPS method, we will test all three Upper Confidence Bounds (Hoeffding, Bernstein and Waudby-Smith–Ramdas).\n", |
Copilot uses AI. Check for mistakes.
7a2bc52 to
2a4eab8
Compare
…ller and from multi_label_classification.py to risk_control.py
…nd update migration guide
2a4eab8 to
97ef755
Compare
Valentin-Laurent
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.