Skip to content

MAINT: cleanup deprecation warning in tests and source code #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 5, 2018

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Sep 5, 2018

Reference Issue

closes #441

What does this implement/fix? Explain your changes.

Remove deprecation warning in testing.

Any other comments?

@pep8speaks
Copy link

pep8speaks commented Sep 5, 2018

Hello @glemaitre! Thanks for updating the PR.

Line 98:80: E501 line too long (80 > 79 characters)

Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file
Line 11:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file
Line 18:1: E402 module level import not at top of file
Line 19:1: E402 module level import not at top of file

Line 198:17: W605 invalid escape sequence '['
Line 198:28: W605 invalid escape sequence ']'

Comment last updated on September 05, 2018 at 22:18 Hours UTC

@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #466 into master will decrease coverage by 2.32%.
The diff coverage is 91.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   98.75%   96.43%   -2.33%     
==========================================
  Files          75       75              
  Lines        4503     4538      +35     
==========================================
- Hits         4447     4376      -71     
- Misses         56      162     +106
Impacted Files Coverage Δ
imblearn/utils/deprecation.py 100% <ø> (ø) ⬆️
imblearn/ensemble/tests/test_easy_ensemble.py 100% <ø> (ø) ⬆️
imblearn/ensemble/_easy_ensemble.py 100% <ø> (ø) ⬆️
imblearn/keras/tests/test_generator.py 10% <0%> (-90%) ⬇️
...rototype_selection/_instance_hardness_threshold.py 100% <100%> (ø) ⬆️
imblearn/utils/estimator_checks.py 96.58% <100%> (+0.13%) ⬆️
imblearn/ensemble/_balance_cascade.py 100% <100%> (ø) ⬆️
imblearn/ensemble/tests/test_balance_cascade.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/tests/test_smote.py 100% <100%> (ø) ⬆️
imblearn/combine/tests/test_smote_tomek.py 100% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a4208...308d786. Read the comment docs.

@glemaitre glemaitre merged commit ff26448 into scikit-learn-contrib:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter deprecation and future warning
2 participants