Skip to content

FIX max_samples was computed on X instead of X_resampled #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2019
Merged

FIX max_samples was computed on X instead of X_resampled #661

merged 4 commits into from
Dec 6, 2019

Conversation

glemaitre
Copy link
Member

Reference Issue

closes #655

What does this implement/fix? Explain your changes.

Any other comments?

@glemaitre glemaitre mentioned this pull request Dec 6, 2019
Closed
@glemaitre glemaitre merged commit 27fbca6 into scikit-learn-contrib:master Dec 6, 2019
glemaitre added a commit that referenced this pull request Dec 7, 2019
@glemaitre
FIX max_samples was computed on X instead of X_resampled (#661)
aa80498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overestimation of OOB score, probable bug in resampling?
1 participant
@glemaitre