Skip to content

Conversation

ckastner
Copy link
Contributor

Closes: #746

Switch to the new parse_version() implementation of scikit-learn 0.23.2, and bump the dependencies.

@pep8speaks
Copy link

Hello @ckastner! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 23:11: F821 undefined name 'version'

@hayesall
Copy link
Member

Thanks for the PR @ckastner.

Could you look at #745?

This statement checks whether numpy is less than 1.7.0, which should be impossible since setup.py requires 'numpy>=1.13.3'. I'd rather drop the statement altogether than force people to upgrade to 0.23.2.

@ckastner
Copy link
Contributor Author

@hayesall I agree, dropping it as in #745 is a much cleaner solution. I overlooked that PR, but also didn't think it through enough (NumPy 1.7 is from early 2013 so perpetuating this check is all but pointless, I guess).

Sorry for the noise!

@ckastner ckastner closed this Aug 17, 2020
@ckastner ckastner deleted the parse_version branch August 17, 2020 18:03
@hayesall
Copy link
Member

No worries, noise happens and I should have cleaned it up sooner. Thank you for your contributions and feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Test fails with newer scikit-learn
3 participants