Skip to content

👷 Drop Windows 32 #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 2, 2022
Merged

👷 Drop Windows 32 #936

merged 10 commits into from
Dec 2, 2022

Conversation

hayesall
Copy link
Member

@hayesall hayesall commented Nov 12, 2022 •
edited
Loading

This drops Windows 32 support (see here: scikit-learn/scikit-learn#24627)

Azure builds were raising an UNEXPECTED EXCEPTION with later versions of scipy. This looks like it may be related to an upcoming API change in the stats.mode method. Alongside #938 this should fix CI.

@hayesall
🐛 Fix FutureWarning in scipy.stats.mode
d33325f 
Azure builds were raising an `UNEXPECTED EXCEPTION` with later versions
of scipy. This looks like it may be related to an upcoming API change
in the `stats.mode` method.

This adds `keepdims=True`
@hayesall
🚨 Fix lint warnings by running black
1dab9be
@codecov
Copy link

codecov bot commented Nov 12, 2022 •
edited
Loading

Codecov Report

Base: 97.19% // Head: 93.27% // Decreases project coverage by -3.92% ⚠️

Coverage data is based on head (6168f83) compared to base (6176807).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   97.19%   93.27%   -3.93%     
==========================================
  Files          97       94       -3     
  Lines        6348     6198     -150     
  Branches      711      848     +137     
==========================================
- Hits         6170     5781     -389     
- Misses        106      355     +249     
+ Partials       72       62      -10
Impacted Files Coverage Δ
imblearn/keras/tests/test_generator.py 7.93% <0.00%> (-92.07%) ⬇️
imblearn/tensorflow/_generator.py 34.37% <0.00%> (-62.50%) ⬇️
imblearn/tests/test_docstring_parameters.py 30.93% <0.00%> (-56.84%) ⬇️
imblearn/tensorflow/tests/test_generator.py 10.75% <0.00%> (-54.84%) ⬇️
imblearn/keras/_generator.py 47.36% <0.00%> (-44.74%) ⬇️
imblearn/datasets/tests/test_zenodo.py 89.18% <0.00%> (-2.71%) ⬇️
imblearn/ensemble/_forest.py 89.30% <0.00%> (-0.63%) ⬇️
imblearn/base.py
imblearn/tests/test_common.py
imblearn/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hayesall hayesall changed the title 🐛 Fix FutureWarning in scipy.stats.mode 👷 Drop -Werror::FutureWarning and Windows 32 Nov 12, 2022
@hayesall hayesall requested a review from glemaitre November 12, 2022 15:57
@hayesall
Copy link
Member Author

hayesall commented Nov 12, 2022 •
edited
Loading

@glemaitre CI is green apart from codecov.

scipy.stats.mode changes are upcoming in 1.11, for now I documented this in #937

The -Werror::FutureWarning is worth keeping in. Combined with the other commit this should get CI back into the green.

@hayesall hayesall changed the title 👷 Drop -Werror::FutureWarning and Windows 32 👷 Drop Windows 32 Nov 12, 2022
@hayesall hayesall mentioned this pull request Dec 2, 2022
Merged
@glemaitre
Copy link
Member

Yep this is the right fix. Switching to meson does not provide the set of build tools for Windows 32 bits for the moment. Merging this one and I will backport in 946.

@glemaitre glemaitre merged commit 291af2e into scikit-learn-contrib:master Dec 2, 2022
@glemaitre
Copy link
Member

Thanks @hayesall

@hayesall hayesall deleted the azure-pipeline-debug branch December 2, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre Awaiting requested review from glemaitre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayesall @glemaitre