Skip to content

Fixed CircleCI badge in README #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

Originally the badges look like this:

image

As you can see, the CircleCI badge is broken. It doesn't seem that token is needed for the badge. This is similar to scikit-learn/scikit-learn#26183

@glemaitre
Copy link
Member

Thanks @Charlie-XIAO I did not see this one.
Merging. The CIs are fixed in master.

@glemaitre glemaitre merged commit c65e21f into scikit-learn-contrib:master Jul 7, 2023
@Charlie-XIAO Charlie-XIAO deleted the circleci-token branch September 23, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants