This repository was archived by the owner on Dec 6, 2023. It is now read-only.
[MRG] Build directly from cython sources #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove .cpp files from repo
477ad9b to
f54f041
Compare
|
Awesome, thanks a lot! LGTM. @fabianp can you take a second look and merge? |
|
looks good to me. merging |
|
Hello, Thanks a lot @lesteve ! |
|
Glad to hear that @casotto ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same approach as in scikit-learn:
As part of this commit the .cpp files have been removed from the repo.