Skip to content

Fix python2.7 compatibility in setup.py #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

Fix python2.7 compatibility in setup.py #126

merged 1 commit into from
Oct 10, 2018

Conversation

terrytangyuan
Copy link
Member

Got the following when running tests under python2.7:

Traceback (most recent call last):
  File "setup.py", line 11, in <module>
    with open('README.rst', encoding='utf-8') as f:
TypeError: 'encoding' is an invalid keyword argument for this function

Reference: https://stackoverflow.com/questions/25049962/is-encoding-is-an-invalid-keyword-error-inevitable-in-python-2-x

@terrytangyuan
Copy link
Member Author

It seems like tests are flaky and not related to this PR.

@wdevazelhes
Copy link
Member

Yes, indeed, master is now failing: I think it must be because of scikit-learn's recent update to 0.20. I'll raise an issue for that.
Running your PR with 0.19.2 version, it passes, so I guess we can merge it and fix the tests in another PR

@perimosocordiae perimosocordiae merged commit 8e607d1 into scikit-learn-contrib:master Oct 10, 2018
@perimosocordiae
Copy link
Contributor

Merged.

@terrytangyuan terrytangyuan deleted the setup-compat-fix branch October 10, 2018 14:08
@wdevazelhes wdevazelhes mentioned this pull request Oct 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrytangyuan @wdevazelhes @perimosocordiae